Skip to content

Change stop watchdog log to verbose info #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Change stop watchdog log to verbose info #1708

merged 1 commit into from
Nov 14, 2025
+1 −1

Conversation

@DavidXU12345
Copy link
Contributor

@DavidXU12345 DavidXU12345 commented Oct 2, 2025

When running test, stopping log for watchdog spams the test log, let's make it verbose level 4 so that it won't show during test.

Is this a bug fix or adding new feature?
Minor change

What is this PR about? / Why do we need it?
the watchdog stopping... log makes it difficult to read the test log, let's make it klog.V(4).Info so that it won't be printed out during test

What testing is done?
N/A

@DavidXU12345
Change stop watchdog log to verbose info
0b76202 
When running test, stopping log for watchdog spams the test log, let's
make it verbose level 4 so that it won't show during test.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 2, 2025

Hi @DavidXU12345. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2025
@DavidXU12345 DavidXU12345 self-assigned this Nov 13, 2025
@DavidXU12345
Copy link
Contributor Author

DavidXU12345 commented Nov 13, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2025
@dankova22
Copy link
Contributor

dankova22 commented Nov 13, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dankova22, DavidXU12345

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DavidXU12345,dankova22]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@DavidXU12345
Copy link
Contributor Author

DavidXU12345 commented Nov 14, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8739e39 into kubernetes-sigs:master Nov 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dankova22 dankova22 dankova22 approved these changes

@mskanth972 mskanth972 Awaiting requested review from mskanth972

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@DavidXU12345 DavidXU12345

@dankova22 dankova22

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidXU12345 @k8s-ci-robot @dankova22